https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h
File test/unittests/compiler/graph-unittest.h (right):
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode78
test/unittests/compiler/graph-unittest.h:78:
Move these helpers to loop-peeling-unittest.cc. Also they should not
depend on GraphTest, but rather take a JSGraph.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode80
test/unittests/compiler/graph-unittest.h:80: struct While {
According to the style guide "structs should be used for passive objects
that carry data, and may have associated constants, but lack any
functionality other than access/setting the data members. The
accessing/setting of fields is done by directly accessing the fields
rather than through method invocations. Methods should not provide
behavior but should only be used to set up the data members, e.g.,
constructor, destructor, Initialize(), Reset(), Validate().", so this
has to be class then. See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Structs_vs._Classes
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode108
test/unittests/compiler/graph-unittest.h:108: struct Branch {
See above.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode123
test/unittests/compiler/graph-unittest.h:123: struct Counter {
See above.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode129
test/unittests/compiler/graph-unittest.h:129: Counter(While& w,
MachineOperatorBuilder* machine, int32_t b, int32_t k)
According to the google style guide: All parameters passed by reference
must be labeled const.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode134
test/unittests/compiler/graph-unittest.h:134: Counter(While& w,
MachineOperatorBuilder* machine, Node* b, Node* k)
According to the google style guide: All parameters passed by reference
must be labeled const.
https://codereview.chromium.org/816053002/diff/40001/test/unittests/compiler/graph-unittest.h#newcode139
test/unittests/compiler/graph-unittest.h:139: void Build(While& w,
MachineOperatorBuilder* machine) {
According to the google style guide: All parameters passed by reference
must be labeled const.
https://codereview.chromium.org/816053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
