LGMT with a few small comments.
http://codereview.chromium.org/300037/diff/4001/4006 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/300037/diff/4001/4006#newcode238 Line 238: __ stm(db_w, sp, r1.bit() | r2.bit() | r3.bit() | r4.bit()); I find it helpful to write these left to right in argument order: __ stm(db_w, sp, r4.bit() | r3.bit() | r2.bit() | r1.bit()) http://codereview.chromium.org/300037/diff/4001/4002 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/300037/diff/4001/4002#newcode365 Line 365: // so do nothing to do here. Extra 'do' in the comment. http://codereview.chromium.org/300037/diff/4001/4005 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/300037/diff/4001/4005#newcode237 Line 237: __ Cmp(rax, Factory::undefined_value()); There is a MacroAssembler::CompareRoot function that you should use here. http://codereview.chromium.org/300037 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
