Reviewers: Michael Starzinger,
Message:
Could you take a look, please?
Description:
[turbofan] Add frame state to the PlainPrimitiveToNumber unit test.
[email protected]
Please review this at https://codereview.chromium.org/792043007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+12, -2 lines):
M test/unittests/compiler/js-typed-lowering-unittest.cc
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc
b/test/unittests/compiler/js-typed-lowering-unittest.cc
index
97ff106329770269274b74bfeef435ed7e63e0a3..42ba64b9bcbc2cc2e3f35d27a8e9cebd6560ba8f
100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -80,6 +80,12 @@ class JSTypedLoweringTest : public TypedGraphTest {
return reducer.Reduce(node);
}
+ Node* EmptyFrameState() {
+ MachineOperatorBuilder machine(zone());
+ JSGraph jsgraph(graph(), common(), javascript(), &machine);
+ return jsgraph.EmptyFrameState();
+ }
+
Handle<JSArrayBuffer> NewArrayBuffer(void* bytes, size_t byte_length) {
Handle<JSArrayBuffer> buffer = factory()->NewJSArrayBuffer();
Runtime::SetupArrayBuffer(isolate(), buffer, true, bytes, byte_length);
@@ -369,8 +375,12 @@ TEST_F(JSTypedLoweringTest,
JSToNumberWithPlainPrimitive) {
Node* const context = Parameter(Type::Any(), 1);
Node* const effect = graph()->start();
Node* const control = graph()->start();
- Reduction r = Reduce(graph()->NewNode(javascript()->ToNumber(), input,
- context, effect, control));
+ Reduction r =
+ FLAG_turbo_deoptimization
+ ? Reduce(graph()->NewNode(javascript()->ToNumber(), input,
context,
+ EmptyFrameState(), effect, control))
+ : Reduce(graph()->NewNode(javascript()->ToNumber(), input,
context,
+ effect, control));
ASSERT_TRUE(r.Changed());
EXPECT_THAT(r.replacement(), IsToNumber(input,
IsNumberConstant(BitEq(0.0)),
graph()->start(), control));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
