On 2015/01/16 23:12:04, adamk wrote:
https://codereview.chromium.org/858673002/diff/20001/src/ast.cc
File src/ast.cc (right):

https://codereview.chromium.org/858673002/diff/20001/src/ast.cc#newcode259
src/ast.cc:259: property->set_emit_store(!seen_prototype);
Probably a dumb question, but does one of your test cases exercise this logic?
I
don't see any places where you set the same thing twice (though some cases set
both [[Prototype]] and create an instance property named "__proto__").

I pretty much assumed that this case would be covered already. I'll add a test
unless I can find an existing test for this already.

https://codereview.chromium.org/858673002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to