LGTM.
http://codereview.chromium.org/321001/diff/1/2 File test/cctest/cctest.status (right): http://codereview.chromium.org/321001/diff/1/2#newcode36 Line 36: # This is about to go away anyway. Maybe elaborate (a bit) on why they are going away? http://codereview.chromium.org/321001/diff/1/3 File test/cctest/test-serialize.cc (right): http://codereview.chromium.org/321001/diff/1/3#newcode291 Line 291: extern "C" void V8_Fatal(const char* file, int line, const char* format, ...); Is that really necessary? You trust V8_Fatal over CHECK, I guess? It looks pretty ugly. http://codereview.chromium.org/321001 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
