Reviewers: jochen (slow), Jakob, tandrii(chromium), tandrii_google,
Message:
Created Revert of Revert of Reland Auto-generate v8 version based on tags.
Description:
Revert of Revert of Reland Auto-generate v8 version based on tags.
(patchset #1
id:1 of https://codereview.chromium.org/855263002/)
Reason for revert:
Next try...
Original issue's description:
Revert of Reland Auto-generate v8 version based on tags. (patchset #1
id:1 of
https://codereview.chromium.org/843913009/)
Reason for revert:
The gclient hook of v8 is not executed on this builder:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/49765
Original issue's description:
> Reland Auto-generate v8 version based on tags.
>
> This relands the CL
> https://codereview.chromium.org/797503007/.
>
> It runs the version generation two times. First during
> runhooks as a fallback for recipes that loose git context
> (e.g. android_aosp). Second during compilation like in the
> original CL. In case of failures, the result from the
> runhooks call will be reused.
>
> BUG=chromium:446166
> LOG=n
>
> Committed: https://crrev.com/d3d6e38b2cba73b52bd5ed00f4441a7db3284a19
> Cr-Commit-Position: refs/heads/master@{#26120}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:446166
Committed: https://crrev.com/12adf1474d92839bd187c4cecc89a5689159575b
Cr-Commit-Position: refs/heads/master@{#26121}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:446166
Please review this at https://codereview.chromium.org/861593002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+138, -20 lines):
M .gitignore
M BUILD.gn
M DEPS
M tools/gyp/v8.gyp
M tools/push-to-trunk/generate_version.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
