Sorry the last patch not lgtm.
You are mixing up raw pointers and handles, that's not good (easy fix too)
https://codereview.chromium.org/851163007/diff/20001/src/runtime/runtime-function.cc
File src/runtime/runtime-function.cc (right):
https://codereview.chromium.org/851163007/diff/20001/src/runtime/runtime-function.cc#newcode333
src/runtime/runtime-function.cc:333: CONVERT_ARG_CHECKED(Object, object,
0);
Must be CONVERT_HANDLE_ARG_CHECKED.
https://codereview.chromium.org/851163007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
