Reviewers: titzer,
Message:
Reason for the change is, that the following two invocation behave
unexpectedly
and surprisingly different:
1) $ d8 --allow-natives-syntax -e "function f() { try {} catch(e) {} } f();
%OptimizeFunctionOnNextCall(f); f();" --turbo-filter=* --trace-opt
2) $ d8 --allow-natives-syntax -e "function f() { try {} catch(e) {} }
%OptimizeFunctionOnNextCall(f); f();" --turbo-filter=* --trace-opt
Here 1) will not enter the optimizing pipeline, because optimization has
been
disabled on the SharedFunctionInfo already, whereas 2) will enter the
optimizing
pipeline and let the pipeline bailout on it's own. I think the pipeline
should
have the final say in this matter.
Description:
Remove overzealous check from %OptimizeFunctionOnNextCall.
[email protected]
Please review this at https://codereview.chromium.org/863443003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -5 lines):
M src/runtime/runtime-test.cc
Index: src/runtime/runtime-test.cc
diff --git a/src/runtime/runtime-test.cc b/src/runtime/runtime-test.cc
index
a66e7665daa98cd4cbb1c555d75c8ca28000c30a..1778401210ccda2573a3f2aa7df5898441dd265f
100644
--- a/src/runtime/runtime-test.cc
+++ b/src/runtime/runtime-test.cc
@@ -64,11 +64,6 @@ RUNTIME_FUNCTION(Runtime_OptimizeFunctionOnNextCall) {
// If the function is already optimized, just return.
if (function->IsOptimized()) return isolate->heap()->undefined_value();
- // If the function cannot optimized, just return.
- if (function->shared()->optimization_disabled()) {
- return isolate->heap()->undefined_value();
- }
-
function->MarkForOptimization();
Code* unoptimized = function->shared()->code();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
