LGTM. Stared long and hard at the matrix index computations, couldn't find
any
bugs, but I am sure they are hiding in there.
https://codereview.chromium.org/855653002/diff/1/src/compiler/loop-analysis.cc
File src/compiler/loop-analysis.cc (right):
https://codereview.chromium.org/855653002/diff/1/src/compiler/loop-analysis.cc#newcode17
src/compiler/loop-analysis.cc:17: #define OFFSET(x) ((x)&0x1f)
nit: Whitespace before and after operator for readability.
https://codereview.chromium.org/855653002/diff/1/test/cctest/compiler/test-loop-analysis.cc
File test/cctest/compiler/test-loop-analysis.cc (right):
https://codereview.chromium.org/855653002/diff/1/test/cctest/compiler/test-loop-analysis.cc#newcode962
test/cctest/compiler/test-loop-analysis.cc:962: TEST(LaManyChained_31) {
RunManyChainedLoops_i(30); }
nit: s/30/31/ here.
https://codereview.chromium.org/855653002/diff/1/test/cctest/compiler/test-loop-analysis.cc#newcode971
test/cctest/compiler/test-loop-analysis.cc:971: TEST(LaManyNested_31) {
RunManyNestedLoops_i(30); }
nit: s/30/31/ here.
https://codereview.chromium.org/855653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
