lgtm
https://codereview.chromium.org/830093003/diff/80001/Makefile
File Makefile (right):
https://codereview.chromium.org/830093003/diff/80001/Makefile#newcode285
Makefile:285: version:
Please add "version" to the .PHONY list above
https://codereview.chromium.org/830093003/diff/80001/Makefile#newcode286
Makefile:286: build/generate_version.py
This is indented with tab, right? Codereview doesn't highlight it for
some reason.
https://codereview.chromium.org/830093003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
