Reviewers: titzer,
Message:
Reason for this change is to increase test coverage for TurboFan. For
example
the harmony/computed-property-names tests only barely trigger failures in
TurboFan (i.e. only in GC-Stress mode).
Description:
Remove early bailout from Runtime_CompileOptimized.
[email protected]
Please review this at https://codereview.chromium.org/857853004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -13 lines):
M src/runtime/runtime-compiler.cc
Index: src/runtime/runtime-compiler.cc
diff --git a/src/runtime/runtime-compiler.cc
b/src/runtime/runtime-compiler.cc
index
7ef287d2a1669433dfee8d34facea444f0936de4..45ed2dd72036dc85b7454599a6d517cc7dec3a78
100644
--- a/src/runtime/runtime-compiler.cc
+++ b/src/runtime/runtime-compiler.cc
@@ -49,22 +49,10 @@ RUNTIME_FUNCTION(Runtime_CompileOptimized) {
CONVERT_BOOLEAN_ARG_CHECKED(concurrent, 1);
DCHECK(isolate->use_crankshaft());
- Handle<Code> unoptimized(function->shared()->code());
- if (function->shared()->optimization_disabled()) {
- // If the function is not optimizable continue using the code from the
full
- // compiler.
- if (FLAG_trace_opt) {
- OFStream os(stdout);
- os << "[failed to optimize " << Brief(*function)
- << ", code is not optimizable]" << std::endl;
- }
- function->ReplaceCode(*unoptimized);
- return function->code();
- }
-
Compiler::ConcurrencyMode mode =
concurrent ? Compiler::CONCURRENT : Compiler::NOT_CONCURRENT;
Handle<Code> code;
+ Handle<Code> unoptimized(function->shared()->code());
if (Compiler::GetOptimizedCode(function, unoptimized,
mode).ToHandle(&code)) {
// Optimization succeeded, return optimized code.
function->ReplaceCode(*code);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
