Reviewers: brettw, eseidel, Michael Achenbach,

Description:
Add initial support for v8_target_arch == "arm" to GN config

BUG=none
[email protected],[email protected],[email protected]
LOG=n

Please review this at https://codereview.chromium.org/863683002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+29, -1 lines):
  M BUILD.gn


Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1605495e6848228df12d8bdfcbb27348ff2fb1e0..18c719d222c8b26361c3419ce7c3aa004767693f 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -8,6 +8,7 @@ import("//build/module_args/v8.gni")

# TODO(jochen): These will need to be user-settable to support standalone V8
 # builds.
+arm_test_noprobe = false
 v8_deprecation_warnings = false
 v8_enable_disassembler = false
 v8_enable_gdbjit = false
@@ -96,8 +97,35 @@ config("toolchain") {
   defines = []
   cflags = []

-  # TODO(jochen): Add support for arm, mips, mipsel.
+  # TODO(jochen): Add support for arm subarchs, mips, mipsel.

+  if (v8_target_arch == "arm") {
+    defines += [ "V8_TARGET_ARCH_ARM" ]
+    if (arm_verson == 7) {
+      defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ]
+    }
+    if (arm_fpu == "vfpv3-d16") {
+      defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ]
+    }
+    if (arm_fpu == "vfpv3") {
+      defines += [
+        "CAN_USE_VFP3_INSTRUCTIONS",
+        "CAN_USE_VFP32DREGS",
+      ]
+    }
+    if (arm_fpu == "neon") {
+      defines += [
+        "CAN_USE_VFP3_INSTRUCTIONS",
+        "CAN_USE_VFP32DREGS",
+        "CAN_USE_NEON",
+      ]
+    }
+    if (arm_test_noprobe) {
+      defines += [ "ARM_TEST_NO_FEATURE_PROBE" ]
+    }
+
+    # TODO(jochen): Add support for cpu_arch != v8_target_arch.
+  }
   if (v8_target_arch == "arm64") {
     defines += [ "V8_TARGET_ARCH_ARM64" ]
   }


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to