Reviewers: jochen (slow), Jakob, tandrii(chromium),
Message:
PTAL
Description:
Ensure tags are fetched when generating the V8 version.
This is needed to work after bot_update fetched v8 in a
chromium checkout.
BUG=chromium:446166
LOG=n
Please review this at https://codereview.chromium.org/860163002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -0 lines):
M build/generate_version.py
Index: build/generate_version.py
diff --git a/build/generate_version.py b/build/generate_version.py
index
2d4c40dba3e8de5dc22bee7032515648d2ddfd09..a7aaee5822c0ec0dc20e3c46b0b05d3bcb4efd9b
100755
--- a/build/generate_version.py
+++ b/build/generate_version.py
@@ -28,6 +28,10 @@ VERSION_GEN_CC =
os.path.join(CWD, "src", "version_gen.cc")
def generate_version_file():
+ # Make sure the tags are fetched.
+ assert (subprocess.call(
+ ["git", "fetch", "origin", "+refs/tags/*:refs/tags/*"],
+ cwd=CWD) == 0)
tag = subprocess.check_output(
"git describe --tags",
shell=True,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
