Reviewers: Weiliang, dcarney,
Message:
PTAL.
Description:
X87: fix debug checks for api callbacks returning symbols
port 3eb589976a979fa80f0934a3754ebc79d289b713.
original commit message:
fix debug checks for api callbacks returning symbols
BUG=
Please review this at https://codereview.chromium.org/864733002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/x87/macro-assembler-x87.cc
Index: src/x87/macro-assembler-x87.cc
diff --git a/src/x87/macro-assembler-x87.cc b/src/x87/macro-assembler-x87.cc
index
5615d4daecda0a62a462259ba8ed4feb4677f533..b9693d14815d9c59e1beb46b3611a263b4e2cb07
100644
--- a/src/x87/macro-assembler-x87.cc
+++ b/src/x87/macro-assembler-x87.cc
@@ -2153,8 +2153,8 @@ void MacroAssembler::CallApiFunctionAndReturn(
JumpIfSmi(return_value, &ok, Label::kNear);
mov(map, FieldOperand(return_value, HeapObject::kMapOffset));
- CmpInstanceType(map, FIRST_NONSTRING_TYPE);
- j(below, &ok, Label::kNear);
+ CmpInstanceType(map, LAST_NAME_TYPE);
+ j(below_equal, &ok, Label::kNear);
CmpInstanceType(map, FIRST_SPEC_OBJECT_TYPE);
j(above_equal, &ok, Label::kNear);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
