Reviewers: Toon Verwaest,
Description:
KeyedStoreIC: support non-generic handling of Symbol keys
BUG=chromium:450475
LOG=n
Please review this at https://codereview.chromium.org/856333002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/ic/ic.cc
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index
88520029132b9daedba28ae1e5650b3994a1f078..8cd06868c0c3fdd215b87d76ec184bad3307c209
100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2035,10 +2035,10 @@ MaybeHandle<Object>
KeyedStoreIC::Store(Handle<Object> object,
Handle<Object> store_handle;
Handle<Code> stub = megamorphic_stub();
- if (key->IsInternalizedString()) {
+ if (key->IsInternalizedString() || key->IsSymbol()) {
ASSIGN_RETURN_ON_EXCEPTION(
isolate(), store_handle,
- StoreIC::Store(object, Handle<String>::cast(key), value,
+ StoreIC::Store(object, Handle<Name>::cast(key), value,
JSReceiver::MAY_BE_STORE_FROM_KEYED),
Object);
if (!is_target_set()) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
