On 2015/01/21 14:59:55, vogelheim wrote:
On 2015/01/21 14:40:40, Yang wrote:
> https://codereview.chromium.org/790413004/diff/1/src/compiler.cc
> File src/compiler.cc (right):
>
>
https://codereview.chromium.org/790413004/diff/1/src/compiler.cc#newcode943
> src/compiler.cc:943: AggregatedHistogramTimerScope
> timer(isolate->counters()->compile_lazy());
> This may be re-entrant. When we compile and encounter a late syntax
error,
that
> error is reported. The error reporting is partly written in JS, which
also
needs
> to be compiled lazily.
>
> See implementation for HistogramTimerScope.
Thanks.
I saw that. My thinking was:
- For HistogramTimerScope, the base::ElapsedTimer - which appears to be
the
problem - is in the timer, not in the scope. So when that function is
called
recursively, two scopes will try to modify the same base::ElapsedTimer
instance
=> problem.
- For my aggregating timer thingy, the ElapsedTimer is in the scopes.
These
are
on the stack and not shared in any fashion, so the problem that two
entities
try
to control the same base::ElapsedTimer shouldn't occur.
Not sure if I was overthinking or underthinking this... wdyt?
I see. Seems alright then.
https://codereview.chromium.org/790413004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
