Reviewers: Benedikt Meurer,
Description:
Add missing FrameState for Runtime_DeliverObservationChangeRecords.
[email protected]
TEST=cctest,mjsunit/es7/object-observe-debug-event
Please review this at https://codereview.chromium.org/790413005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -4 lines):
M src/compiler/linkage.cc
M test/cctest/cctest.status
M test/mjsunit/mjsunit.status
Index: src/compiler/linkage.cc
diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc
index
4b301f512f9afc5737d59676fb640c7c0c96bcbe..0ed81b4978f91402fb200b5ce3a74fb03365e9e2
100644
--- a/src/compiler/linkage.cc
+++ b/src/compiler/linkage.cc
@@ -155,6 +155,7 @@ bool Linkage::NeedsFrameState(Runtime::FunctionId
function) {
case Runtime::kDefineAccessorPropertyUnchecked:
case Runtime::kDefineDataPropertyUnchecked:
case Runtime::kDeleteProperty:
+ case Runtime::kDeliverObservationChangeRecords:
case Runtime::kDeoptimizeFunction:
case Runtime::kFunctionBindArguments:
case Runtime::kGetDefaultReceiver:
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
77e2082021c37a7178593c84cf12af8f4fd192ec..78723b362d070a82d79646274084947eaf0d64a7
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -96,11 +96,8 @@
'test-debug/DebugStepFunctionCall': [PASS, NO_VARIANTS],
# TODO(jarin): Some tests don't like --turbo-deoptimzation very much.
- 'test-api/ApiUncaughtExceptionInObjectObserve': [PASS, NO_VARIANTS],
'test-api/GetPrototypeAccessControl': [PASS, NO_VARIANTS],
'test-api/Regress93759': [PASS, NO_VARIANTS],
- 'test-debug/DebugBreakOnExceptionInObserveCallback': [PASS, NO_VARIANTS],
- 'test-object-observe/DeliveryCallbackThrows': [PASS, NO_VARIANTS],
# TODO(titzer): Triggers bug in late control reduction.
'test-run-inlining/InlineLoopGuardedEmpty': [SKIP],
Index: test/mjsunit/mjsunit.status
diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status
index
c8d2126a1f03bddbcf215e946997fcb3a5ff02b4..f2a94ff4b8f0a923713382dc546868ee5e4aca5a
100644
--- a/test/mjsunit/mjsunit.status
+++ b/test/mjsunit/mjsunit.status
@@ -106,7 +106,6 @@
# TODO(jarin): Some tests don't like --turbo-deoptimzation very much.
'asm/embenchen/lua_binarytrees': [SKIP],
'es6/symbols': [PASS, NO_VARIANTS],
- 'es7/object-observe-debug-event': [PASS, NO_VARIANTS],
'harmony/classes': [PASS, NO_VARIANTS],
'regress/regress-354433': [PASS, NO_VARIANTS], # only on ARM simulator.
'regress/regress-crbug-259300': [PASS, NO_VARIANTS],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
