Reviewers: Jakob,
Description:
Double field values need sNaN -> qNaN canonicalization.
Also fix mjsunit/regress/regress-undefined-nan to ensure that we are
testing transfer via xmm registers by forcing the transfer to be in an
optimized function.
BUG=v8:3839
LOG=n
[email protected]
Please review this at https://codereview.chromium.org/863153002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+29, -10 lines):
M src/hydrogen-instructions.cc
M test/mjsunit/regress/regress-undefined-nan.js
A + test/mjsunit/regress/regress-undefined-nan3.js
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
18bc67c5cd4082b517d7182597bce731a7e0054c..20d67100552a370305bf73d49e8fa6ca0f51a2b9
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -4063,9 +4063,11 @@ bool HStoreKeyed::NeedsCanonicalization() {
Representation from = HChange::cast(value())->from();
return from.IsTagged() || from.IsHeapObject();
}
- case kPhi:
+ case kLoadNamedField:
+ case kPhi: {
// Better safe than sorry...
return true;
+ }
default:
return false;
}
Index: test/mjsunit/regress/regress-undefined-nan.js
diff --git a/test/mjsunit/regress/regress-undefined-nan.js
b/test/mjsunit/regress/regress-undefined-nan.js
index
cbbb182eeeef31aca7ff5da10a9ce6a15bf3fbd4..93106c5eb17522afef4eae47a4d1f6677dcc8e1f
100644
--- a/test/mjsunit/regress/regress-undefined-nan.js
+++ b/test/mjsunit/regress/regress-undefined-nan.js
@@ -15,7 +15,17 @@ i_view[1] = 0xFFF7FFFF;
var f_view = new Float64Array(ab);
var fixed_double_elements = new Float64Array(1);
-fixed_double_elements[0] = f_view[0];
+
+function opt_store() { fixed_double_elements[0] = f_view[0]; }
+
+opt_store();
+opt_store();
+%OptimizeFunctionOnNextCall(opt_store);
+opt_store();
+
+var i32 = new Int32Array(fixed_double_elements.buffer);
+assertEquals(i_view[0], i32[0]);
+assertEquals(i_view[1], i32[1]);
var doubles = [0.5];
loader(doubles, fixed_double_elements, 0);
Index: test/mjsunit/regress/regress-undefined-nan3.js
diff --git a/test/mjsunit/regress/regress-undefined-nan.js
b/test/mjsunit/regress/regress-undefined-nan3.js
similarity index 60%
copy from test/mjsunit/regress/regress-undefined-nan.js
copy to test/mjsunit/regress/regress-undefined-nan3.js
index
cbbb182eeeef31aca7ff5da10a9ce6a15bf3fbd4..636b38a1101a84c661ef5b74bca953eff0338e47
100644
--- a/test/mjsunit/regress/regress-undefined-nan.js
+++ b/test/mjsunit/regress/regress-undefined-nan3.js
@@ -4,10 +4,6 @@
// Flags: --allow-natives-syntax
-function loader(dst, src, i) {
- dst[i] = src[i];
-}
-
var ab = new ArrayBuffer(8);
var i_view = new Int32Array(ab);
i_view[0] = 0xFFF7FFFF;
@@ -17,9 +13,20 @@ var f_view = new Float64Array(ab);
var fixed_double_elements = new Float64Array(1);
fixed_double_elements[0] = f_view[0];
+function A(src) { this.x = src[0]; }
+
+new A(fixed_double_elements);
+new A(fixed_double_elements);
+
+%OptimizeFunctionOnNextCall(A);
+
+var obj = new A(fixed_double_elements);
+
+function move_x(dst, obj) { dst[0] = obj.x; }
+
var doubles = [0.5];
-loader(doubles, fixed_double_elements, 0);
-loader(doubles, fixed_double_elements, 0);
-%OptimizeFunctionOnNextCall(loader);
-loader(doubles, fixed_double_elements, 0);
+move_x(doubles, obj);
+move_x(doubles, obj);
+%OptimizeFunctionOnNextCall(move_x);
+move_x(doubles, obj);
assertTrue(doubles[0] !== undefined);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
