Reviewers: Benedikt Meurer,
Description:
Removed bogus threading test to make TSAN happy.
TSAN hits an internal assertion on a self-join, and the test is not
really that useful, so let's just remove it.
BUG=https://code.google.com/p/thread-sanitizer/issues/detail?id=88
LOG=y
Please review this at https://codereview.chromium.org/824243007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -18 lines):
M test/unittests/base/platform/platform-unittest.cc
Index: test/unittests/base/platform/platform-unittest.cc
diff --git a/test/unittests/base/platform/platform-unittest.cc
b/test/unittests/base/platform/platform-unittest.cc
index
b17a9b9ef49b6c0737b6480af52d2cee09ac86ed..8392b55462446cc13cf09546b5e6cf84743f8f66
100644
--- a/test/unittests/base/platform/platform-unittest.cc
+++ b/test/unittests/base/platform/platform-unittest.cc
@@ -36,24 +36,6 @@ TEST(OS, GetCurrentProcessId) {
namespace {
-class SelfJoinThread FINAL : public Thread {
- public:
- SelfJoinThread() : Thread(Options("SelfJoinThread")) {}
- void Run() FINAL { Join(); }
-};
-
-} // namespace
-
-
-TEST(Thread, DISABLE_ON_ANDROID(SelfJoin)) {
- SelfJoinThread thread;
- thread.Start();
- thread.Join();
-}
-
-
-namespace {
-
class ThreadLocalStorageTest : public Thread, public ::testing::Test {
public:
ThreadLocalStorageTest() : Thread(Options("ThreadLocalStorageTest")) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
