All comments addressed + more polish.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):
https://codereview.chromium.org/803933008/diff/20001/src/ia32/builtins-ia32.cc#newcode162
src/ia32/builtins-ia32.cc:162: // runtime call made it for us, and we
shouldn't do create count
On 2015/01/21 19:18:55, arv wrote:
this sentence could use some polish
Done, also removed code duplication.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc#newcode3144
src/ia32/full-codegen-ia32.cc:3144:
On 2015/01/21 19:18:55, arv wrote:
remove one empty line
Done.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc#newcode3163
src/ia32/full-codegen-ia32.cc:3163: CHECK(false);
On 2015/01/21 19:18:56, arv wrote:
UNREACHABLE()
Done.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc#newcode3165
src/ia32/full-codegen-ia32.cc:3165:
EnsureSlotContainsAllocationSite(expr->AllocationSiteFeedbackSlot());
On 2015/01/21 19:18:56, arv wrote:
TODO
Done.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc#newcode3174
src/ia32/full-codegen-ia32.cc:3174: CallConstructStub stub(isolate(),
RECORD_CONSTRUCTOR_TARGET);
On 2015/01/21 19:18:55, arv wrote:
It is not clear to me where NewTarget is pushed on the stack?
Not yet, added a todo.
https://codereview.chromium.org/803933008/diff/20001/src/ia32/full-codegen-ia32.cc#newcode3180
src/ia32/full-codegen-ia32.cc:3180:
EmitVariableAssignment(super_ref->this_var()->var(), Token::INIT_LET);
On 2015/01/21 19:18:56, arv wrote:
Or INIT_CONST?
Added a TODO to revisit this after TDZ is implemented
https://codereview.chromium.org/803933008/diff/20001/src/runtime/runtime-object.cc
File src/runtime/runtime-object.cc (right):
https://codereview.chromium.org/803933008/diff/20001/src/runtime/runtime-object.cc#newcode1350
src/runtime/runtime-object.cc:1350: CHECK(*constructor ==
*original_constructor);
On 2015/01/21 19:18:56, arv wrote:
Why are we passing two args here?
We will need both args once prototype rewiring is implenmented.
Added comment and TODO.
https://codereview.chromium.org/803933008/diff/20001/test/mjsunit/harmony/classes-experimental.js
File test/mjsunit/harmony/classes-experimental.js (right):
https://codereview.chromium.org/803933008/diff/20001/test/mjsunit/harmony/classes-experimental.js#newcode21
test/mjsunit/harmony/classes-experimental.js:21: } catch(ReferenceError)
{}
On 2015/01/21 19:18:56, arv wrote:
This does not do what you think it does.
Change it to:
var ex;
try {
this.prp1 = 3;
} catch (e) {
ex = e;
}
assertTrue(ex instanceof ReferenceError);
Right! Changed code, added a TODO to actually test when this is
implemented
https://codereview.chromium.org/803933008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
