feedback addressed
https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/graph-reducer-unittest.cc
File test/unittests/compiler/graph-reducer-unittest.cc (right):
https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/graph-reducer-unittest.cc#newcode22
test/unittests/compiler/graph-reducer-unittest.cc:22: struct
TestOperator : public Operator {
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
Please move the TestOperator into the anonymous namespace below.
Done.
https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/graph-reducer-unittest.cc#newcode32
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t
OPCODE_A0 = 10;
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
Can we rename these to kOpcodeA0, etc.
Done.
https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/graph-reducer-unittest.cc#newcode32
test/unittests/compiler/graph-reducer-unittest.cc:32: const uint8_t
OPCODE_A0 = 10;
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
Can we rename these to kOpcodeA0, etc.
Done.
https://codereview.chromium.org/867583002/diff/20001/test/unittests/compiler/graph-reducer-unittest.cc#newcode42
test/unittests/compiler/graph-reducer-unittest.cc:42: static
TestOperator OPA0(OPCODE_A0, Operator::kNoWrite, "opa1", 0, 1);
On 2015/01/22 13:33:44, Benedikt Meurer wrote:
Can we rename these to kOpA0, etc.
Done.
https://codereview.chromium.org/867583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
