LGTM if nits are addressed.
https://codereview.chromium.org/819593003/diff/20001/src/compiler/control-builders.h
File src/compiler/control-builders.h (right):
https://codereview.chromium.org/819593003/diff/20001/src/compiler/control-builders.h#newcode29
src/compiler/control-builders.h:29: virtual void Exit() { /* do nothing.
*/
nit: Can we make it unreachable and only override it to do nothing for
breakable builders (i.e. for SwitchBuilder and BlockBuilder)?
https://codereview.chromium.org/819593003/diff/20001/src/compiler/control-builders.h#newcode81
src/compiler/control-builders.h:81:
nit: Remove the empty newline for consistency.
https://codereview.chromium.org/819593003/diff/20001/src/compiler/graph-builder.cc
File src/compiler/graph-builder.cc (right):
https://codereview.chromium.org/819593003/diff/20001/src/compiler/graph-builder.cc#newcode219
src/compiler/graph-builder.cc:219: static bool IsPhiWithControl(Node*
maybe_phi, Node* control) {
nit: Maybe "IsPhiOwnedBy"?
https://codereview.chromium.org/819593003/diff/20001/src/compiler/graph-builder.cc#newcode228
src/compiler/graph-builder.cc:228: DCHECK(loop_header->values()->size()
= values()->size());
nit: Can we do this check on the top, before the early return (i.e. move
up two lines)?
https://codereview.chromium.org/819593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
