LGTM, but please fix the nits.
https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc
File src/mips/full-codegen-mips.cc (right):
https://codereview.chromium.org/871693002/diff/1/src/mips/full-codegen-mips.cc#newcode3241
src/mips/full-codegen-mips.cc:3241: // Load function and argument count
into r1 and r0.
Nit: fix register names in comment.
https://codereview.chromium.org/871693002/diff/1/src/mips64/full-codegen-mips64.cc
File src/mips64/full-codegen-mips64.cc (right):
https://codereview.chromium.org/871693002/diff/1/src/mips64/full-codegen-mips64.cc#newcode3239
src/mips64/full-codegen-mips64.cc:3239: // Load function and argument
count into r1 and r0.
nit: fix reg names here, too.
https://codereview.chromium.org/871693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
