Reviewers: Igor Sheludko,
Message:
PTAL. Thanks for the suggestion Igor.
Description:
Make TestSetJitCodeEventHandler more resilient.
[email protected]
TEST=cctest/test-api/SetJitCodeEventHandler
Please review this at https://codereview.chromium.org/874493002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -1 lines):
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
4d39aa543d6f79e96d1e5879f94d53638e1eebc4..c3fc8214b80a1b6f36dd25bbd29db967045499d5
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -15104,6 +15104,9 @@ UNINITIALIZED_TEST(SetJitCodeEventHandler) {
i::Isolate* i_isolate = reinterpret_cast<i::Isolate*>(isolate);
i::Heap* heap = i_isolate->heap();
+ // Start with a clean slate.
+ heap->CollectAllAvailableGarbage("TestSetJitCodeEventHandler_Prepare");
+
{
v8::HandleScope scope(isolate);
i::HashMap code(MatchPointers);
@@ -15137,7 +15140,7 @@ UNINITIALIZED_TEST(SetJitCodeEventHandler) {
}
// Force code movement.
- heap->CollectAllAvailableGarbage("TestSetJitCodeEventHandler");
+ heap->CollectAllAvailableGarbage("TestSetJitCodeEventHandler_Move");
isolate->SetJitCodeEventHandler(v8::kJitCodeEventDefault, NULL);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
