Reviewers: danno, paul.l..., gergely.kis.imgtec, akos.palfi.imgtec,
dusmil.imgtec,
Description:
MIPS64: Remove the dependency of Zone on Isolate.
Port c7b09aac317dd810d29b82061973199b80363b65
Original commit message:
Along the way:
- Thread isolate parameter explicitly through code that used to
rely on getting it from the zone.
- Canonicalize the parameter position of isolate and zone for
affected code
- Change Hydrogen New<> instruction templates to automatically
pass isolate
LOG=N
BUG=
Please review this at https://codereview.chromium.org/875533002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -14 lines):
M src/compiler/mips64/linkage-mips64.cc
M src/mips64/regexp-macro-assembler-mips64.h
M src/mips64/regexp-macro-assembler-mips64.cc
Index: src/compiler/mips64/linkage-mips64.cc
diff --git a/src/compiler/mips64/linkage-mips64.cc
b/src/compiler/mips64/linkage-mips64.cc
index
0e1a5900c1e64ffd161e90092db3fddbd2abe570..fbd6fef4aa00b74b0a1d7a12a3313d6a343a40a0
100644
--- a/src/compiler/mips64/linkage-mips64.cc
+++ b/src/compiler/mips64/linkage-mips64.cc
@@ -35,25 +35,26 @@ struct MipsLinkageHelperTraits {
typedef LinkageHelper<MipsLinkageHelperTraits> LH;
-CallDescriptor* Linkage::GetJSCallDescriptor(int parameter_count, Zone*
zone,
+CallDescriptor* Linkage::GetJSCallDescriptor(Zone* zone, int
parameter_count,
CallDescriptor::Flags flags) {
return LH::GetJSCallDescriptor(zone, parameter_count, flags);
}
CallDescriptor* Linkage::GetRuntimeCallDescriptor(
- Runtime::FunctionId function, int parameter_count,
- Operator::Properties properties, Zone* zone) {
+ Zone* zone, Runtime::FunctionId function, int parameter_count,
+ Operator::Properties properties) {
return LH::GetRuntimeCallDescriptor(zone, function, parameter_count,
properties);
}
CallDescriptor* Linkage::GetStubCallDescriptor(
- const CallInterfaceDescriptor& descriptor, int stack_parameter_count,
- CallDescriptor::Flags flags, Operator::Properties properties, Zone*
zone) {
- return LH::GetStubCallDescriptor(zone, descriptor, stack_parameter_count,
- flags, properties);
+ Isolate* isolate, Zone* zone, const CallInterfaceDescriptor&
descriptor,
+ int stack_parameter_count, CallDescriptor::Flags flags,
+ Operator::Properties properties) {
+ return LH::GetStubCallDescriptor(isolate, zone, descriptor,
+ stack_parameter_count, flags,
properties);
}
Index: src/mips64/regexp-macro-assembler-mips64.cc
diff --git a/src/mips64/regexp-macro-assembler-mips64.cc
b/src/mips64/regexp-macro-assembler-mips64.cc
index
b20cab98258deeb96cf2bc0fd06ac009f3e7f62c..c1c0e4c2ea88429c765761452b8f1e6d2d992a5b
100644
--- a/src/mips64/regexp-macro-assembler-mips64.cc
+++ b/src/mips64/regexp-macro-assembler-mips64.cc
@@ -131,12 +131,11 @@ namespace internal {
#define __ ACCESS_MASM(masm_)
-RegExpMacroAssemblerMIPS::RegExpMacroAssemblerMIPS(
- Mode mode,
- int registers_to_save,
- Zone* zone)
- : NativeRegExpMacroAssembler(zone),
- masm_(new MacroAssembler(zone->isolate(), NULL, kRegExpCodeSize)),
+RegExpMacroAssemblerMIPS::RegExpMacroAssemblerMIPS(Isolate* isolate, Zone*
zone,
+ Mode mode,
+ int registers_to_save)
+ : NativeRegExpMacroAssembler(isolate, zone),
+ masm_(new MacroAssembler(isolate, NULL, kRegExpCodeSize)),
mode_(mode),
num_registers_(registers_to_save),
num_saved_registers_(registers_to_save),
Index: src/mips64/regexp-macro-assembler-mips64.h
diff --git a/src/mips64/regexp-macro-assembler-mips64.h
b/src/mips64/regexp-macro-assembler-mips64.h
index
dd4e8a93bcaf09c1297ab2fcee431af7b74950dc..ae4d25b79aaf473211cfaf4dd1ad95953ebd82df
100644
--- a/src/mips64/regexp-macro-assembler-mips64.h
+++ b/src/mips64/regexp-macro-assembler-mips64.h
@@ -17,7 +17,8 @@ namespace internal {
#ifndef V8_INTERPRETED_REGEXP
class RegExpMacroAssemblerMIPS: public NativeRegExpMacroAssembler {
public:
- RegExpMacroAssemblerMIPS(Mode mode, int registers_to_save, Zone* zone);
+ RegExpMacroAssemblerMIPS(Isolate* isolate, Zone* zone, Mode mode,
+ int registers_to_save);
virtual ~RegExpMacroAssemblerMIPS();
virtual int stack_limit_slack();
virtual void AdvanceCurrentPosition(int by);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
