LGTM.
http://codereview.chromium.org/316009/diff/7002/7008 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/316009/diff/7002/7008#newcode277 Line 277: __ ldr(r0, MemOperand(sp)); On 2009/10/26 12:17:33, fschneider wrote: > On 2009/10/24 07:30:08, Kevin Millikin wrote: > > The value restored to r0 from the stack is the same as the one already in r0 > > returned by the runtime. > Done. SetProperty return the value not the receiver in r0. So we have to save r0 > in this case. I fixed this also on ia32 and x64. Good catch. http://codereview.chromium.org/316009 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
