On 2015/01/26 17:16:56, Michael Starzinger wrote:
LGTM, just one comment.
https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h
File src/compiler/all-nodes.h (right):
https://codereview.chromium.org/879583002/diff/1/src/compiler/all-nodes.h#newcode19
src/compiler/all-nodes.h:19: class AllNodes {
I think this class should live in the graph.h file. WDYT?
I agree, but I think we should smash node.h, node-matcher.h, and this one
into
graph.h all in one go. If I leave this file separate for now, then it's at
least
more consistent.
https://codereview.chromium.org/879583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
