LGTM, just nits. Thanks for simplifying this.
https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.cc
File src/allocation-tracker.cc (right):
https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.cc#newcode225
src/allocation-tracker.cc:225: bool IsFillerOrFreeListNode(HeapObject*
object) {
Rename to IsFillerOrFreeSpace
https://codereview.chromium.org/876613002/diff/20001/src/allocation-tracker.cc#newcode243
src/allocation-tracker.cc:243:
DCHECK(IsFillerOrFreeListNode(HeapObject::FromAddress(addr)));
I don't think the two DCHECKs above are useful. We can trust our
CreateFillerObjectAt method. You can remove them.
https://codereview.chromium.org/876613002/diff/20001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4451
src/objects.h:4451: // FreeSpace are free blocks in the heap. They look
like heap objects
... are fixed size memory blocks...
https://codereview.chromium.org/876613002/diff/20001/src/objects.h#newcode4454
src/objects.h:4454: // of the next FreeSpace object (or NULL) in the
free list.
Used by the heap and GC.
https://codereview.chromium.org/876613002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
