Reviewers: tandrii(chromium),
Message:
PTAL
https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py
File tools/release/common_includes.py (left):
https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py#oldcode602
tools/release/common_includes.py:602: if len(version_parts) == 3:
This was a mistake. The version is used to later checkout based on it.
Therefore it needs to match the tag.
https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py
File tools/release/common_includes.py (right):
https://codereview.chromium.org/878913002/diff/1/tools/release/common_includes.py#newcode48
tools/release/common_includes.py:48: CHANGELOG_FILE = "ChangeLog"
This was moved from push_to_candidates.
https://codereview.chromium.org/878913002/diff/1/tools/release/push_to_candidates.py
File tools/release/push_to_candidates.py (left):
https://codereview.chromium.org/878913002/diff/1/tools/release/push_to_candidates.py#oldcode82
tools/release/push_to_candidates.py:82: # Print assumed commit,
circumventing git's pager.
This interaction was never used -> remove.
Description:
Let release scripts determine version based on tags.
Also create new v8 versions based on the roll ref, which
has some more verification steps than the candidate ref.
Improve bailout regarding existing versions. Only create a
new version if the revisions is in the future.
BUG=chromium:451975
[email protected]
NOTRY=true
LOG=n
Please review this at https://codereview.chromium.org/878913002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+111, -136 lines):
M tools/release/auto_push.py
M tools/release/auto_roll.py
M tools/release/chromium_roll.py
M tools/release/common_includes.py
M tools/release/push_to_candidates.py
M tools/release/test_scripts.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
