Reviewers: titzer,
Description:
[turbofan] Ensure that NTLs are always properly connected to the end.
Up until now we used a special Terminate node to artifically connect non
terminating loops to the End node, but this was kind of adhoc and didn't
work for the CFG. So without all kinds of weird hacks, the end block in
the CFG will not be connected to NTLs, which makes it impossible to
compute post dominance / control dependence in the current setting.
So instead of Terminate, we add a special Branch to NTLs, whose
condition is the special Always node, which corresponds to True, except
that it cannot be folded away. This way we don't need any special
machinery in the scheduler, since it's just a regular Branch.
[email protected]
Please review this at https://codereview.chromium.org/875263004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+333, -255 lines):
M src/compiler/common-operator.h
M src/compiler/common-operator.cc
M src/compiler/control-reducer.h
M src/compiler/control-reducer.cc
M src/compiler/instruction-selector.cc
M src/compiler/js-generic-lowering.cc
M src/compiler/opcodes.h
M src/compiler/scheduler.cc
M src/compiler/simplified-lowering.cc
M src/compiler/typer.cc
M src/compiler/verifier.cc
M test/cctest/compiler/test-control-reducer.cc
M test/unittests/compiler/common-operator-unittest.cc
A test/unittests/compiler/control-reducer-unittest.cc
M test/unittests/compiler/graph-unittest.h
M test/unittests/compiler/graph-unittest.cc
M test/unittests/compiler/node-test-utils.h
M test/unittests/compiler/node-test-utils.cc
M test/unittests/compiler/scheduler-unittest.cc
M test/unittests/unittests.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
