This is for people who refuse to run "gclient sync", right? Not sure we even
want to support that situation, since it's likely to introduce further
issues
down the road... such as, tests won't even compile.
https://codereview.chromium.org/876323002/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/876323002/diff/1/Makefile#newcode51
Makefile:51: # library=shared || component=shared_library
+1 to alphabetical sorting, but please move the
"component=shared_library" part of this comment where it belongs now
(i.e. before "ifdef component").
https://codereview.chromium.org/876323002/diff/1/Makefile#newcode56
Makefile:56: ifeq ($(clang), on)
On 2015/01/27 14:46:54, bnoordhuis wrote:
Maybe this should check for 'off', to keep the default `make` behavior
the same?
Absolutely. Not specifying anything should build with clang. In fact,
you don't need -Dclang=1 in that case.
https://codereview.chromium.org/876323002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
