On 2015/01/27 19:13:20, rossberg wrote:
OK, why did the previous isolate hack not work?

Are the changes with respect to representations just temporary hacks as well?
Not sure I understand them.

Yes, the plan is to make the representations be really separate from the
semantic part.

The problem was that type Any with no representation bit sets is considered
inhabited, but in various places I ignored ranges with empty representations
(because I though they were uninhabited). The 'fix' just does not remove ranges with empty representations as aggressively. I am still not entirely sure we will always be fine, but all this is temporary until we separate the representations,
so I just want to make the tests happy.

As for the i::Isolate::Current() hack, this should go away really soon - I am
working on using unboxed doubles in ranges (well, at least in the zone).

https://codereview.chromium.org/877643002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to