LGTM, with a couple small fixups. The IA32 comments apply to the other platforms as well.
http://codereview.chromium.org/334041/diff/1/6 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/334041/diff/1/6#newcode595 Line 595: __ add(sp, sp, Operand(kPointerSize)); You should write __ pop() on ARM. http://codereview.chromium.org/334041/diff/1/2 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/334041/diff/1/2#newcode551 Line 551: void FastCodeGenerator::VisitCallNew(CallNew* node) { We've been trying to keep these sorted in AST node order (as in ast.h), so CallNew goes after Call and before CallRuntime. http://codereview.chromium.org/334041/diff/1/2#newcode586 Line 586: if (node->location().is_temporary()) { Write this as a switch over (node->location().type()) for now, so we'll get compilation failures rather than ASSERT failures if we forget a case. http://codereview.chromium.org/334041 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
