On 2015/01/30 04:50:09, Benedikt Meurer wrote:
I think this is something that can only be solved properly by adding
support
for
64bit integers to representation selection (i.e. simplified lowering).
Otherwise it is unsound because the index is not guaranteed to be
constrained
to
31-bit unsigned integer.
The index is constrained to be a 31-bit unsigned integer because: it is an
array
buffer index, and the maximum array buffer size is 2GB, and at this point
in the
code the index is known to be within bounds?
Hydrogen has logic for dehoisting these offsets too, see
hydrogen-dehoist.cc,
and I have some wip patches to generalize this to work better on asm.js
style
accesses. The turbofan code looks much cleaner.
https://codereview.chromium.org/860283004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
