On 2015/01/30 11:06:26, bnoordhuis wrote:
On 2015/01/30 10:14:59, Yang wrote:
> Not sure about this CL. The flags by themselves are fine. The problem
only
> happens if you multiply the flag values after reading them out when we
> initialize the heap. Can't we simply cast up before multiplying?
Certainly, but then people need to remember to widen the type every time
they
use it in a calculation. Changing the type avoids a whole class of future
bugs.
My initial take changed all int flags to int64_t. I still think that's a
good
idea but I figured it was perhaps too audacious.
alright lgtm.
https://codereview.chromium.org/890563003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
