LGTM. On Tue, Oct 27, 2009 at 7:51 PM, <[email protected]> wrote:
> Reviewers: Kevin Millikin, > > Message: > Small bug fix of the property access code in the fast compiler. > > > > Description: > Fix missing recording of source position for property access in fast > compiler. > > > Please review this at http://codereview.chromium.org/341002 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/arm/fast-codegen-arm.cc > M src/ia32/fast-codegen-ia32.cc > M src/x64/fast-codegen-x64.cc > > > Index: src/ia32/fast-codegen-ia32.cc > =================================================================== > --- src/ia32/fast-codegen-ia32.cc (revision 3152) > +++ src/ia32/fast-codegen-ia32.cc (working copy) > @@ -498,6 +498,9 @@ > Expression* key = expr->key(); > uint32_t dummy; > > + // Record the source position for the property load. > + SetSourcePosition(expr->position()); > + > // Evaluate receiver. > Visit(expr->obj()); > > Index: src/x64/fast-codegen-x64.cc > =================================================================== > --- src/x64/fast-codegen-x64.cc (revision 3152) > +++ src/x64/fast-codegen-x64.cc (working copy) > @@ -511,6 +511,9 @@ > Expression* key = expr->key(); > uint32_t dummy; > > + // Record the source position for the property load. > + SetSourcePosition(expr->position()); > + > // Evaluate receiver. > Visit(expr->obj()); > > Index: src/arm/fast-codegen-arm.cc > =================================================================== > --- src/arm/fast-codegen-arm.cc (revision 3152) > +++ src/arm/fast-codegen-arm.cc (working copy) > @@ -502,6 +502,9 @@ > Expression* key = expr->key(); > uint32_t dummy; > > + // Record the source position for the property load. > + SetSourcePosition(expr->position()); > + > // Evaluate receiver. > Visit(expr->obj()); > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
