Reviewers: jarin, titzer,
Message:
Note that this only implements local exceptional control-flow (as
in 'throw' in
the same function as the 'try'). Implicit exceptional control-flow from
calls is
not covered.
Also there is still one issue with bailout-ids I still need to address
before
being able to land this. But please feel free to shoot a first round of
comments
my way while I work on that.
https://codereview.chromium.org/873423004/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/873423004/diff/1/src/compiler/ast-graph-builder.cc#newcode2570
src/compiler/ast-graph-builder.cc:2570: // TODO(mstarzinger): Thread
through the correct bailout id to this point.
This is the TODO I still need to address.
Description:
First stab at try-catch and try-finally in TurboFan.
[email protected],[email protected]
TEST=cctest/test-run-jsexceptions
Please review this at https://codereview.chromium.org/873423004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+608, -66 lines):
M src/compiler/ast-graph-builder.h
M src/compiler/ast-graph-builder.cc
M src/compiler/control-builders.h
M src/compiler/control-builders.cc
M src/compiler/graph-builder.h
M src/compiler/js-generic-lowering.cc
M src/compiler/js-operator.cc
M src/flag-definitions.h
M test/cctest/compiler/test-run-jsexceptions.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
