Reviewers: tandrii(chromium),
Message:
PTAL. Big parts of the new script are copied from the old
push_to_candidates. I
won't invest into code sharing as the old script is going to be deleted. I
marked the step classes that were copied to ease review.
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py
File tools/release/create_release.py (right):
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode50
tools/release/create_release.py:50: class IncrementVersion(Step):
Copied.
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode77
tools/release/create_release.py:77: # The new version is not a
candidate.
Small change to the original to make sure that this is not a candidate,
but a real release.
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode94
tools/release/create_release.py:94: class PrepareChangeLog(Step):
Copied
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode147
tools/release/create_release.py:147: class EditChangeLog(Step):
Copied
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode181
tools/release/create_release.py:181: MESSAGE = "Add ChangeLog changes to
release branch."
Copied
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode197
tools/release/create_release.py:197: class CommitBranch(Step):
Partially copied (changed commit message and commit to branch in the
end)
Description:
Add new script to create release branches.
BUG=chromium:451975
[email protected]
NOTRY=true
LOG=n
TEST=./script_test.py
TEST=tools/release/create_release.py -r [email protected] -a
[email protected] --dry-run
Please review this at https://codereview.chromium.org/881683004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+423, -0 lines):
M tools/release/common_includes.py
A tools/release/create_release.py
M tools/release/test_scripts.py
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
