lgtm
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py
File tools/release/create_release.py (right):
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode38
tools/release/create_release.py:38: print "Release revision %s" %
self["push_hash"]
How about swapping lines assert with print? If assert fails, having the
value printed would be nice.
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode212
tools/release/create_release.py:212: text = SplitMapJoin("\n\n",
SplitMapJoin("\n", strip, " "), "\n\n")(text)
nit: I really liked your recent "str.strip" intead of "lambda line:
line.strip()" .
of course, it's not Py3 compatible, but who cares?!
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode262
tools/release/create_release.py:262: self.DeleteBranch("work-branch")
I wonder, is it useful to run git.gc here?
https://codereview.chromium.org/881683004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
