Reviewers: paul.l..., akos.palfi.imgtec, balazs.kilvady,
Description:
MIPS: Fix bug in elements transition code for smi to double transitions.
This fixes intermittent sin-cos test failures when corrupted values are
returned
for referent sin and cos functions in test which require factorial value
to be calculated.
TEST=mjsunit/sin-cos
BUG=
Please review this at https://codereview.chromium.org/885923004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/mips/codegen-mips.cc
Index: src/mips/codegen-mips.cc
diff --git a/src/mips/codegen-mips.cc b/src/mips/codegen-mips.cc
index
9188f7b2b0374069348f4ee2c909b35d21fa9e40..a04b8cb0e753065b06e603f284400b77f8b14702
100644
--- a/src/mips/codegen-mips.cc
+++ b/src/mips/codegen-mips.cc
@@ -827,9 +827,9 @@ void ElementsTransitionGenerator::GenerateSmiToDouble(
__ sw(hole_lower, MemOperand(scratch3, Register::kMantissaOffset));
// exponent
__ sw(hole_upper, MemOperand(scratch3, Register::kExponentOffset));
- __ bind(&entry);
__ addiu(scratch3, scratch3, kDoubleSize);
+ __ bind(&entry);
__ Branch(&loop, lt, scratch3, Operand(array_end));
__ bind(&done);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
