Status: New
Owner: ----

New issue 3857 by [email protected]: max_old_space_size broken for increasing heap size
https://code.google.com/p/v8/issues/detail?id=3857

You can no longer make the heap size on a 64-bit machine greater than 2047Mbtes, because some casting code was lost between the end of 3.27.0 and 3.27.1

Currently, in ConfigureHeap() in heap.cc, we have this code:


if (max_old_space_size > 0) {
  max_old_generation_size_ = max_old_space_size * MB;
}

Since max_old_space_size is an int, (max_old_space_size * MB) will wrap around and might be negative, and will certainly never be 2Gbytes or greater.

This code needs to change to

  max_old_generation_size_ = static_cast<intptr_t>(max_old_space_size) * MB;


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to