It might be worth mentioning in description that in case of syntax error
call
stack is empty and cannot be used to derive location.
https://codereview.chromium.org/885043002/diff/20001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/885043002/diff/20001/src/isolate.cc#newcode1080
src/isolate.cc:1080: const int start_pos_value =
Handle<Smi>::cast(start_pos)->value();
style: We normally don't mark local variables as const even if they are
only read in the rest of code. The only exception is constants whose
value is known at compile time.
https://codereview.chromium.org/885043002/diff/20001/src/isolate.cc#newcode1093
src/isolate.cc:1093: Handle<Script>
casted_script(Script::cast(*script));
typo: casted -> cast
https://codereview.chromium.org/885043002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
https://codereview.chromium.org/885043002/diff/20001/test/cctest/test-api.cc#oldcode18156
test/cctest/test-api.cc:18156: promise_reject_line_number =
stack_trace->GetFrame(0)->GetLineNumber();
Now we don't check line number in the stack trace, is that intentional?
Also it would make sense to add column number checks in other places if
you validate it in the new test.
https://codereview.chromium.org/885043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
