LGTM. Few small comments.
http://codereview.chromium.org/340005/diff/1/4 File src/compiler.cc (right): http://codereview.chromium.org/340005/diff/1/4#newcode51 Line 51: location_(Location::Nowhere()) { I'm not sure: Should this match the default location for ast nodes(TEMP)? http://codereview.chromium.org/340005/diff/1/4#newcode778 Line 778: Visit(expr->key()); Also set location here: expr->set_location(location_); http://codereview.chromium.org/340005/diff/1/4#newcode814 Line 814: } Also set location here: expr->set_location(location_); http://codereview.chromium.org/340005 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
