Revision: 3158
Author: [email protected]
Date: Wed Oct 28 03:19:56 2009
Log: Add fast check for NaN in NumberCompare slow case.
Review URL: http://codereview.chromium.org/344010
http://code.google.com/p/v8/source/detail?r=3158
Modified:
/branches/bleeding_edge/src/runtime.js
=======================================
--- /branches/bleeding_edge/src/runtime.js Fri Jul 3 03:09:59 2009
+++ /branches/bleeding_edge/src/runtime.js Wed Oct 28 03:19:56 2009
@@ -128,7 +128,10 @@
if (IS_STRING(a) && IS_STRING(b)) {
return %StringCompare(a, b);
} else {
- return %NumberCompare(%ToNumber(a), %ToNumber(b), ncr);
+ var a_number = %ToNumber(a);
+ var b_number = %ToNumber(b);
+ if (NUMBER_IS_NAN(a_number) || NUMBER_IS_NAN(b_number)) return ncr;
+ return %NumberCompare(a_number, b_number, ncr);
}
}
--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---
