lgtm
https://codereview.chromium.org/894683003/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/894683003/diff/40001/src/objects-inl.h#newcode5818
src/objects-inl.h:5818: DCHECK(!is_strict(this->language_mode()) ||
is_strict(language_mode));
On 2015/02/03 14:45:02, marja wrote:
On 2015/02/03 12:26:20, rossberg wrote:
> Maybe abstract that into an is_stricter_than predicate.
That seems overkill; this is now easier to read after adding
is_sloppy:
is_sloppy(this->language_mode()) || is_strict(language_mode)
(And this occurs in... 2 places, I think)
The reason I thought this would be useful is that the condition might
get more complicated once we add more modes, and should hence be next to
the mode definition itself. There might also arise additional places
where it comes up.
But I'm fine with deferring this.
https://codereview.chromium.org/894683003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
