Hello Daniel,

Sure. Here is a build errors without this patch:

/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:6:10:
fatal error: 'v8.h' file not found
#include "v8.h"
         ^

After fixing include paths:

/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:34:24:
error: use of undeclared identifier 'kFailureTag'
int v8dbg_FailureTag = kFailureTag;
                       ^
/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:35:28:
error: use of undeclared identifier 'kFailureTagMask'
int v8dbg_FailureTagMask = kFailureTagMask;
                           ^
/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:54:37:
error: use of undeclared identifier 'TRANSITION'
int v8dbg_prop_type_first_phantom = TRANSITION;
                                    ^
/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:65:48:
error: no member named 'kElementsKindMask' in 'v8::internal::Map'
int v8dbg_bit_field2_elements_kind_mask = Map::kElementsKindMask;
                                          ~~~~~^
/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:66:44:
error: no member named 'kElementsKindShift' in 'v8::internal::Map'; did you mean
'kElementsKindCount'?
int v8dbg_bit_field2_elements_kind_shift = Map::kElementsKindShift;
                                           ^~~~~~~~~~~~~~~~~~~~~~~
                                           kElementsKindCount
../deps/v8/src/elements-kind.h:66:11: note: 'kElementsKindCount' declared here
const int kElementsKindCount = LAST_ELEMENTS_KIND - FIRST_ELEMENTS_KIND + 1;
          ^
/Users/indutny/Code/indutny/node/out/Release/obj/gen/debug-support.cc:340:74:
error: no member named 'kUniqueIdOffset' in 'v8::internal::SharedFunctionInfo'
int v8dbg_class_SharedFunctionInfo__unique_id__SMI =
SharedFunctionInfo::kUniqueIdOffset;



https://codereview.chromium.org/894003003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to