Reviewers: danno,
Description:
tools: fix postmortem generator
BUG=
R=danno
Please review this at https://codereview.chromium.org/894003003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -12 lines):
M src/globals.h
M src/objects.h
M tools/gen-postmortem-metadata.py
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index
1eb12953035604b4811d00075b782687a3470bc9..6cdd35422403715b6df782f2e1d00668f76ba978
100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -567,9 +567,6 @@ struct AccessorDescriptor {
#define HAS_SMI_TAG(value) \
((reinterpret_cast<intptr_t>(value) & kSmiTagMask) == kSmiTag)
-#define HAS_FAILURE_TAG(value) \
- ((reinterpret_cast<intptr_t>(value) & kFailureTagMask) == kFailureTag)
-
// OBJECT_POINTER_ALIGN returns the value aligned as a HeapObject pointer
#define OBJECT_POINTER_ALIGN(value) \
(((value) + kObjectAlignmentMask) & ~kObjectAlignmentMask)
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
93c39281ca90f728627bf73745089db317868abc..919a5583156c8320d0640dff9b669c7311d089de
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -7071,6 +7071,8 @@ class SharedFunctionInfo: public HeapObject {
static const int kUniqueIdOffset = kFeedbackVectorOffset + kPointerSize;
static const int kLastPointerFieldOffset = kUniqueIdOffset;
#else
+ // Just to not break the postmortrem support with conditional offsets
+ static const int kUniqueIdOffset = kFeedbackVectorOffset;
static const int kLastPointerFieldOffset = kFeedbackVectorOffset;
#endif
Index: tools/gen-postmortem-metadata.py
diff --git a/tools/gen-postmortem-metadata.py
b/tools/gen-postmortem-metadata.py
index
04a1ea87f4afaf73745d696b5ca895358c2cbad6..62e103a73597140f4a7f064c4fb3f671f6d14e7b
100644
--- a/tools/gen-postmortem-metadata.py
+++ b/tools/gen-postmortem-metadata.py
@@ -70,8 +70,6 @@ consts_misc = [
{ 'name': 'ExternalStringTag', 'value': 'kExternalStringTag' },
{ 'name': 'SlicedStringTag', 'value': 'kSlicedStringTag' },
- { 'name': 'FailureTag', 'value': 'kFailureTag' },
- { 'name': 'FailureTagMask', 'value': 'kFailureTagMask' },
{ 'name': 'HeapObjectTag', 'value': 'kHeapObjectTag' },
{ 'name': 'HeapObjectTagMask', 'value': 'kHeapObjectTagMask' },
{ 'name': 'SmiTag', 'value': 'kSmiTag' },
@@ -94,8 +92,6 @@ consts_misc = [
'value': 'DescriptorArray::kFirstIndex' },
{ 'name': 'prop_type_field',
'value': 'FIELD' },
- { 'name': 'prop_type_first_phantom',
- 'value': 'TRANSITION' },
{ 'name': 'prop_type_mask',
'value': 'PropertyDetails::TypeField::kMask' },
{ 'name': 'prop_index_mask',
@@ -120,9 +116,9 @@ consts_misc = [
'value': 'DICTIONARY_ELEMENTS' },
{ 'name': 'bit_field2_elements_kind_mask',
- 'value': 'Map::kElementsKindMask' },
+ 'value': 'Map::ElementsKindBits::kMask' },
{ 'name': 'bit_field2_elements_kind_shift',
- 'value': 'Map::kElementsKindShift' },
+ 'value': 'Map::ElementsKindBits::kShift' },
{ 'name': 'bit_field3_dictionary_map_shift',
'value': 'Map::DictionaryMap::kShift' },
@@ -196,9 +192,9 @@ header = '''
* This file is generated by %s. Do not edit directly.
*/
-#include "v8.h"
-#include "frames.h"
-#include "frames-inl.h" /* for architecture-specific frame constants */
+#include "src/v8.h"
+#include "src/frames.h"
+#include "src/frames-inl.h" /* for architecture-specific frame constants */
using namespace v8::internal;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
