Reviewers: Yang, Sven Panne,
Message:
PTAL
Description:
shell.cc race condition
BUG=v8:3850
Please review this at https://codereview.chromium.org/892083002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -1 lines):
M AUTHORS
M samples/shell.cc
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
c22d2e1dd872bc7c324996d99120b886acaa9610..30a76cc9d5630525b2e96a4238ae4cd145e67be6
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -52,6 +52,7 @@ Fedor Indutny <[email protected]>
Felix Geisendörfer <[email protected]>
Filipe David Manana <[email protected]>
Geoffrey Garside <[email protected]>
+Han Choongwoo <[email protected]>
Hirofumi Mako <[email protected]>
Ioseb Dzmanashvili <[email protected]>
Isiah Meadows <[email protected]>
@@ -92,4 +93,4 @@ Vlad Burlik <[email protected]>
Vladimir Shutoff <[email protected]>
Yu Yin <[email protected]>
Zhongping Wang <[email protected]>
-柳荣一 <[email protected]>
\ No newline at end of file
+柳荣一 <[email protected]>
Index: samples/shell.cc
diff --git a/samples/shell.cc b/samples/shell.cc
index
1a08afffdc8ad211ec10adb898ab943427ed1b5b..0ed742d3e368ffbb3d5b60e14020e542ab01fccb
100644
--- a/samples/shell.cc
+++ b/samples/shell.cc
@@ -98,6 +98,7 @@ int main(int argc, char* argv[]) {
result = RunMain(isolate, argc, argv);
if (run_shell) RunShell(context);
}
+ isolate->Dispose();
v8::V8::Dispose();
v8::V8::ShutdownPlatform();
delete platform;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
