LGTM, just nits.
https://codereview.chromium.org/894703002/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/894703002/diff/1/src/heap/heap.h#newcode760
src/heap/heap.h:760: void OverApproximateWeakClosure(const char*
gc_reason);
Please add a comment here how the over approximation works.
https://codereview.chromium.org/894703002/diff/1/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/894703002/diff/1/src/heap/incremental-marking.cc#newcode499
src/heap/incremental-marking.cc:499: weak_closure_was_overapproximated_
= false;
Can we do that in the gc epilogue?
https://codereview.chromium.org/894703002/diff/1/src/heap/incremental-marking.cc#newcode785
src/heap/incremental-marking.cc:785: if (FLAG_trace_incremental_marking)
{
Can we add a separate method for that and dispatch between over
approximate and dispatch at the call site?
https://codereview.chromium.org/894703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
