Reviewers: arv,
Message:
PTAL --- this works for me when running the failed commands listed in
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/1964/steps/Check/logs/ObjectProtoToStringES6
So I think that should fix it... other option is revert, apply fix and
re-land I
guess? Up to you
Description:
Fix test-api/ObjectProtoToStringES6
Fixes tree closure caused by r26415
BUG=v8:3502
[email protected]
LOG=N
Please review this at https://codereview.chromium.org/869773005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M test/cctest/test-api.cc
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
b8cf20dd5b0924490fdcb5b57ed484e51797e9b4..dd5358c6c35f67b386807ee5e314c7038c0d3ab3
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -14020,7 +14020,7 @@ TEST(ObjectProtoToStringES6) {
Local<Value> valueNumber = v8_num(123);
Local<v8::Symbol> valueSymbol = v8_symbol("TestSymbol");
Local<v8::Function> valueFunction =
- CompileRun("function fn() {}").As<v8::Function>();
+ CompileRun("(function fn() {})").As<v8::Function>();
Local<v8::Object> valueObject =
v8::Object::New(v8::Isolate::GetCurrent());
Local<v8::Primitive> valueNull = v8::Null(v8::Isolate::GetCurrent());
Local<v8::Primitive> valueUndef =
v8::Undefined(v8::Isolate::GetCurrent());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
